This article explores effective mathematics teaching as constructed in Finnish and Swedish teacher educators’ discourses. Teacher educators in both countries bring into play a variety of aspects identified in the field of mathematics education research, when talking about good mathematics teachers/teaching. The teachers often talk about the same general categories, but a deeper analysis reveals a substantial difference between the characters of the discourses concerning how most of these categories are conceptualized.