This study examines eight teacher educators’ practice and vision of good teaching of primary mathematics. The author concludes that it is clear that teacher educators’ practice and vision of good teaching play a critical role in shaping learning opportunities of pre-service teachers and teacher education reform will not succeed without reforming the way teacher educators learn to teach pre-service teachers.